Disable windows installer #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good! Are we sure this is an actual issue though? I haven't seen it happen on anyone else's box. Other than that, 👍 for merge. If you do merge, ping me and I'll deploy. |
|
It seems that @BrettASwift had a similar issue when he installed. Weird, though, that I didn't. I think we should take it down until we can verify it's safe. I'd rather do that than have someone else tell us that we hosed their PATH and now none of their applications can be found. |
eric79
added a commit
that referenced
this pull request
Mar 8, 2014
…nstaller Disable windows installer
|
@jessmartin it's merged now, if you wouldn't mind redeploying. |
|
Roger that. Deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove Windows installer from website until we can verify that it does not overwrite the user's PATH variable (see issue)
@jessmartin would you mind reviewing?